fix(config): the named cortex map lifts plugins and nli; 1.9.1 - #121
Merged
Merged
Conversation
`extractFromNamedCortexMap` copied store/embed/llm, their option blocks and the tool list from the primary entry, and nothing else. `plugins` and `nli` live on CortexConfig beside those fields, so a repo that declared its own plugin under `cortex.<agent>.plugins:` in the agent.yaml `fozikio init` writes had it silently dropped: only the legacy flat `cortex:` block ever carried the field through. 1.9.0 opened the trusted plugin path for exactly this case (#114), so the config it is declared from has to reach the loader. Co-Authored-By: Claude Opus 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extractFromNamedCortexMapnow liftspluginsandnlifrom the primary entry, the same way it lifts the provider fields. Before, only the legacy flatcortex:block passed them through, so a plugin declared undercortex.<agent>.plugins:in theagent.yamlthatfozikio initwrites never loaded — which defeats the trusted plugin path 1.9.0 added for repo-shipped plugins (A ledger namespace: consolidation off or non-rewriting, observe creating on link, and name/category/tags on observe #114).loadConfigover a tempagent.yamlin the named format assertsplugins,nli,collections_prefixandcognitive_toolsall arrive. Red without the fix, green with it.Test plan
npm run buildnpm test(431 passing)v1.9.1after merge; the publish workflow ships it🤖 Generated with Claude Code